search

videojs / font

Icon font used for Video.js
https://videojs.github.io/font/
Apache License 2.0
60 stars 79 forks source link

Add Picture-in-Picture icons #41

Closed beaufortfrancois closed 5 years ago

beaufortfrancois commented 5 years ago

Following https://github.com/videojs/video.js/issues/5824#issuecomment-494143138, this PR adds two new icons for Picture-in-Picture.

image

gkatsev commented 5 years ago

Also, ignore travis, it's not really set up to verify things just yet :)

thijstriemstra commented 5 years ago

Also, ignore travis, it's not really set up to verify things just yet :)

See #43

beaufortfrancois commented 5 years ago

@gkatsev I don't see Picture-in-Picture icons in https://videojs.github.io/font/. Is that intended?

thijstriemstra commented 5 years ago

@beaufortfrancois the preview html wasn't updated (in this PR) it seems update: oops, not true: https://github.com/videojs/font/blob/master/index.html#L229

beaufortfrancois commented 5 years ago

Oooh! https://github.com/videojs/font/blob/gh-pages/index.html was NOT actually. It looks like gh-pages branch was not updated while master was.

gkatsev commented 5 years ago

I updated it to just use the master branch instead of gh-pages. So, it should be up-to-date now.