Closed roman-bc-dev closed 1 year ago
Did icon codepoints change?
We shouldn't be changing codepoints of the icons, it'll break folks and require changes in video.js as well.
Good point. It hasn't been published yet, we'll make it a 4.0.
The codepoints are autogenerated. Does that mean we have to keep the order of previous icons listed as we add new ones? Or are we ok with modifying them as long as we tag the change as major?
the order of the icons.json is unfortunately, important. Should be purely additive to make it non-breaking. Unfortunately, this was probably never documented anywhere.
Fwiw, I would recommend updating it to only add the new icons at the end of the list so all the existing codepoints don't change.
Honestly, let's just delete 3.3.0 (it hasn't been npm publish
ed) and tag 4.0.0.
No, it wasn't documented. We will have to modify them if we want to remove unused icons. Like gplus in this case.
Should either do a major or not remove things 😅
Unfortunately, once we had things set up, this repo didn't get much love. One potential addition is to augment icons.json
with the codepoint to use for the icon. Though, then the generators would need to be updated to account for that as well.
I guess webfont-generator does have a way to specify codepoints https://github.com/sunflowerdeath/webfonts-generator#codepoints
Add the following icons to default set:
Remove:
General improvements:
lts/gallium