feat: Add default icons and general project updates

videojs / font

Icon font used for Video.js

https://videojs.github.io/font/

Apache License 2.0

60 stars 79 forks source link

feat: Add default icons and general project updates #47

Closed roman-bc-dev closed 1 year ago

roman-bc-dev commented 1 year ago

Add the following icons to default set:

forward-30
replay-30
forward-10
replay-10
forward-5
replay-5
cast
repeat
shuffle
file-download
file-download-off
file-download-done
downloading

Remove:

gplus

General improvements:

Change .nvmrc to require lts/gallium
Update dependencies to latest versions along with any associated config
Remove lodash dependency and replace used methods in code
Overall grunt.js code updates
Update hbs template for index.html sample for formatting and terseness
Update readme to describe Material Design Icon v4 inclusion as custom SVGs

gkatsev commented 1 year ago

Did icon codepoints change?

gkatsev commented 1 year ago

We shouldn't be changing codepoints of the icons, it'll break folks and require changes in video.js as well.

misteroneill commented 1 year ago

Good point. It hasn't been published yet, we'll make it a 4.0.

roman-bc-dev commented 1 year ago

The codepoints are autogenerated. Does that mean we have to keep the order of previous icons listed as we add new ones? Or are we ok with modifying them as long as we tag the change as major?

gkatsev commented 1 year ago

the order of the icons.json is unfortunately, important. Should be purely additive to make it non-breaking. Unfortunately, this was probably never documented anywhere.

gkatsev commented 1 year ago

Fwiw, I would recommend updating it to only add the new icons at the end of the list so all the existing codepoints don't change.

misteroneill commented 1 year ago

Honestly, let's just delete 3.3.0 (it hasn't been npm published) and tag 4.0.0.

roman-bc-dev commented 1 year ago

No, it wasn't documented. We will have to modify them if we want to remove unused icons. Like gplus in this case.

gkatsev commented 1 year ago

Should either do a major or not remove things 😅 Unfortunately, once we had things set up, this repo didn't get much love. One potential addition is to augment icons.json with the codepoint to use for the icon. Though, then the generators would need to be updated to account for that as well.

gkatsev commented 1 year ago

I guess webfont-generator does have a way to specify codepoints https://github.com/sunflowerdeath/webfonts-generator#codepoints