videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 418 forks source link

Object as a source for mpeg dash - placeholder-uri #1280

Open JeppeTh opened 2 years ago

JeppeTh commented 2 years ago

Please do not delete the template, by filling out the required information we can investigate your issue more quickly.

Before opening an issue see if your problem can be resolved with the troubleshooting guide.

Description

I'm trying out "Object as a source" for mpeg-dash. I manage to create a manifest using the mpd-parser. But I can't get it working since some placeholder-uri-[0-9] URLs are requested. Since manifest.uri is '' videojs are requesting a local file that doesn't exist. I'm guessing this placeholder-uri isn't relevant for mpeg-dash? So is this a bug or am I doing something wrong?

Sources

Steps to reproduce

Results

Expected

Error output

Additional Information

videojs-http-streaming version

videojs-http-streaming 2.13.1

videojs version

what version of videojs does this occur with? video.js 7.18.0

Browsers

Platforms

Other Plugins

are any other videojs plugins being used on the page? If so, please list them with version below.

Other JavaScript

JeppeTh commented 2 years ago

After some more googling I see this

// TODO: Should we create the dummy uris in mpd-parser as well (leaning towards yes).

https://github.com/videojs/http-streaming/blob/2c4c77e72910c59b985335b43c412daae5730d80/src/dash-playlist-loader.js#L446

Yes please ;)