Closed dzianis-dashkevich closed 1 year ago
Merging #1360 (5b877a9) into main (d7e8713) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
+ Coverage 86.01% 86.03% +0.01%
==========================================
Files 40 40
Lines 9842 9855 +13
Branches 2294 2295 +1
==========================================
+ Hits 8466 8479 +13
Misses 1376 1376
Impacted Files | Coverage Δ | |
---|---|---|
src/playlist-controller.js | 95.18% <100.00%> (+0.06%) |
:arrow_up: |
src/videojs-http-streaming.js | 90.61% <100.00%> (+0.13%) |
:arrow_up: |
src/vtt-segment-loader.js | 80.79% <100.00%> (-0.33%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
We have a bug with default options setup for HLS in-manifest VTT in chrome iOS (and I assume other non-safari Webkit-based iOS browsers). The problem is that we do not load
vtt.js
, but we useVHS
to handle playback.vtt-segment-loader
implicitly depends onwindow.WebVTT.Parser
. Sincevtt.js
is not loaded -window.WebVTT
isundefined
. It means that we are not able to parse received VTT cues.Specific Changes proposed
vtt.js
invtt-segment-loader
if we do not have it loaded. (eg: forceoverrideNative
option case).Requirements Checklist