search

videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 419 forks source link

Why does emsg ID3 metadata only work if it's on a video track? #1379

Closed tari-hi closed 1 year ago

tari-hi commented 1 year ago

Description

As currently developed, the video track must be present to get the emsg ID3 metadata. If you check the development source, if the audio track contains emsg ID3 metadata, it will not be processed. Is there a reason for this development? Is there a plan to process emsg ID3 meta regardless of audio track and video track?

Sources

https://github.com/videojs/http-streaming/blob/main/src/media-segment-request.js#L503

Additional Information

videojs-http-streaming version

videojs-http-streaming 3.1.0

welcome[bot] commented 1 year ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

adrums86 commented 1 year ago

This is known and will be worked on when time allows. Your pull request is welcome. Thank you for filing the issue!

adrums86 commented 1 year ago

@tari-hi Here's the pull request for the fix: https://github.com/videojs/http-streaming/pull/1385. Do you have any sample media available for verification?