videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 419 forks source link

feat: add event stream support #1382

Closed adrums86 closed 1 year ago

adrums86 commented 1 year ago

Description

~Note: This is marked as a draft until the mpd-parser changes are integrated.~ See EventStream PR to mpd-parser: https://github.com/videojs/mpd-parser/pull/170

This pull request will take the parsed EventStream data and convert it into a id3-like object which can be added to the metadata text track for use as timed metadata.

Specific Changes proposed

Taking the EventStream data from the parsed manifest produced in the handleMain function in the dash-playlist-loader then adding it to the timed metadata text-track via the addMetadata function.

Requirements Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1382 (421adde) into main (6bd98d0) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
+ Coverage   85.37%   85.40%   +0.03%     
==========================================
  Files          40       40              
  Lines        9954     9963       +9     
  Branches     2308     2308              
==========================================
+ Hits         8498     8509      +11     
+ Misses       1456     1454       -2     
Impacted Files Coverage Δ
src/dash-playlist-loader.js 90.51% <100.00%> (+0.18%) :arrow_up:
src/playlist-controller.js 95.16% <100.00%> (+0.03%) :arrow_up:
src/segment-loader.js 96.46% <100.00%> (+0.08%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

adrums86 commented 1 year ago

@dzianis-dashkevich and @wseymour15 I pushed the refactor, I would appreciate another look at the PR when you have time. Thanks!

wseymour15 commented 1 year ago

@dzianis-dashkevich and @wseymour15 I pushed the refactor, I would appreciate another look at the PR when you have time. Thanks!

Looks good to me!