videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 419 forks source link

fix: allow audio fmp4 emsg probe #1385

Closed adrums86 closed 1 year ago

adrums86 commented 1 year ago

Description

Fixes https://github.com/videojs/http-streaming/issues/1379

Specific Changes proposed

Change the order of nested callbacks to the transmuxer to allow for fmp4 audio EMSG id3 metadata probing.

Requirements Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1385 (a1cef32) into main (9520070) will not change coverage. The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          40       40           
  Lines        9953     9953           
  Branches     2307     2307           
=======================================
  Hits         8497     8497           
  Misses       1456     1456           
Impacted Files Coverage Δ
src/media-segment-request.js 95.50% <90.90%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more