search

videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 419 forks source link

Playback freezes on muted ts segment and doesn't recover #1390

Open DerSimeon opened 1 year ago

DerSimeon commented 1 year ago

Please do not delete the template, by filling out the required information we can investigate your issue more quickly.

Before opening an issue see if your problem can be resolved with the troubleshooting guide.

Description

We have a long VOD that is split into 10 second .ts segments. Most of them are fine but some of them have muted audio since they contain copyrighted songs. Apparently Twitch messes something up when muting them, resulting in choppy and laggy playback on windows and ffmpeg reporting they are faulty. Despite my best efforts to fix them using ffmpeg and various google searches I have had no success. VideoJS while loading them via a hls playlist freezes, the timer continues to run but the image is stuck. After a few minutes once the muted segments are over I can hear audio again but the image is still frozen. Even with debug enabled I can't seem to find anything out of line.

Sources

Is a certain source or a certain segment affected? please provide a public (accessible over the internet) link to it below. Yes every muted segment downloaded from Twitch VODs.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Download a muted Twitch VOD Segment
  2. Attempt to play it via Video.JS
  3. voila.

Results

Expected

I expect the video playback to continue, the audio is muted and that is not a problem, we have added a banner to notify the users that some parts are muted. The Video Playback tho, should continue without issues.

Error output

None

Additional Information

Please include any additional information necessary here. Including the following:

videojs-http-streaming version

what version of videojs-http-streaming does this occur with? The Version that is included in the video.js version below.

videojs version

what version of videojs does this occur with? video.js 7.21.4

Browsers

what browsers are affected? please include browser and version for each

Platforms

what platforms are affected? please include operating system and version or device and version for each

Other Plugins

are any other videojs plugins being used on the page? If so, please list them with version below.

Other JavaScript

are you using any other javascript libraries or frameworks on the page? if so please list them below.

welcome[bot] commented 1 year ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

DerSimeon commented 1 year ago

Just a small update, in order to double check if its caused by videojs or by the footage I used https://github.com/video-dev/hls.js (and their demo at: https://hlsjs.video-dev.org/demo) and saw that this player can playback the footage without issues.

So this must be a video.js issue, I really hope this helps you guys since I don't want to redo all the styling and setting up for a completely different player

mister-ben commented 1 year ago

Do you have some example content?

DerSimeon commented 1 year ago

I can give you a link privately somewhere

DerSimeon commented 1 year ago

Is it okay for you @mister-ben if I email you with the email provided in your Github Profile?