videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.49k stars 422 forks source link

ArrayBuffer.isView may not be available everywhere - again #1394

Closed JeppeTh closed 1 year ago

JeppeTh commented 1 year ago

I reported this previously for #1134 Now I get TypeError undefined again for some other live stream. This time inside createTransferableMessage

`

var createTransferableMessage = function createTransferableMessage(message) {
  var transferable = {};
  Object.keys(message).forEach(function (key) {
    var value = message[key];

    if (ArrayBuffer.isView(value)) {
      transferable[key] = {
        bytes: value.buffer,
        byteOffset: value.byteOffset,
        byteLength: value.byteLength
      };
    } else {
      transferable[key] = value;
    }
  });
  return transferable;
};

`

Just add a check if isView is a function doesn't help my play the stream in this case though - possible there are other side effects that needs to be handled.

JeppeTh commented 1 year ago

Sorry - I was running an old version before the fix was applied. :D Tried 2.14.2 - don't get that above problem. Even if my stream still doesn't work. Sorry.