feat: enable caption positioning

wseymour15 commented 1 year ago

Description

This consumes the work completed in mux.js here: https://github.com/videojs/mux.js/pull/434

The goal of this work is to ensure that we can position CEA 608 captions. The bulk of the work was done in mux.js, but this just ensures that we take that data and turn them into valid VTTCues . This will ensure that the captions are positioned correctly based on that CEA 608 caption data.

To Test

Pull down this branch and run npm i and npm start, and then navigate to http://localhost:9999. In the closed caption menu, choose the CC1 option and see that the captions are positioned in different places on the screen.

Specific Changes proposed

Package updates to mux.js and video.js
Ensuring we add the correct properties to VTTCues per caption sent to VHS.
Tests regarding the above

Requirements Checklist

[x] Feature implemented / Bug fixed
[x] If necessary, more likely in a feature request than a bug fix
- [x] Unit Tests updated or fixed
- [ ] Docs/guides updated
- [ ] Example created (starter template on JSBin)
[ ] Reviewed by Two Core Contributors

welcome[bot] commented 1 year ago

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

Run npm run lint -- --errors locally to catch formatting errors earlier.
Include tests when adding/changing behavior.
Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1408 (79a10fe) into main (7c0e968) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
+ Coverage   85.54%   85.55%   +0.01%     
==========================================
  Files          41       41              
  Lines       10125    10143      +18     
  Branches     2345     2349       +4     
==========================================
+ Hits         8661     8678      +17     
- Misses       1464     1465       +1

Impacted Files	Coverage Δ
src/util/text-tracks.js	`89.39% <100.00%> (+0.68%)`	:arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! 🎉🎉🎉

videojs / http-streaming