videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.53k stars 425 forks source link

fix: remove segment loader abort in setCurrentTime #1415

Closed adrums86 closed 1 year ago

adrums86 commented 1 year ago

Description

Removing the abort call from setCurrentTime makes seeking and certain playlist switching cases more resilient. This is because setCurrentTime was essentially calling abort on all the segment loaders twice. Once in the setCurrentTime function directly, then from resetEverything which eventually calls resyncLoader which also calls abort on the segment loader.

Specific Changes proposed

Remove the abort calls on all segment loaders and fix the tests.

Requirements Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1415 (fd44c5c) into main (de183c8) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   85.55%   85.56%           
=======================================
  Files          41       41           
  Lines       10145    10142    -3     
  Branches     2351     2351           
=======================================
- Hits         8680     8678    -2     
+ Misses       1465     1464    -1     
Files Changed Coverage Δ
src/playlist-controller.js 95.33% <ø> (+0.10%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more