Closed adrums86 closed 1 year ago
Merging #1415 (fd44c5c) into main (de183c8) will increase coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
Coverage 85.55% 85.56%
=======================================
Files 41 41
Lines 10145 10142 -3
Branches 2351 2351
=======================================
- Hits 8680 8678 -2
+ Misses 1465 1464 -1
Files Changed | Coverage Δ | |
---|---|---|
src/playlist-controller.js | 95.33% <ø> (+0.10%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
Removing the
abort
call fromsetCurrentTime
makes seeking and certain playlist switching cases more resilient. This is becausesetCurrentTime
was essentially calling abort on all the segment loaders twice. Once in thesetCurrentTime
function directly, then fromresetEverything
which eventually callsresyncLoader
which also callsabort
on the segment loader.Specific Changes proposed
Remove the
abort
calls on all segment loaders and fix the tests.Requirements Checklist