Live Audio issue - Githubissues

Wadimir commented 10 months ago

Please do not delete the template, by filling out the required information we can investigate your issue more quickly.

Before opening an issue see if your problem can be resolved with the troubleshooting guide.

Description

I found a bug when playing Live audio. playlist-loader.js has condition https://github.com/videojs/http-streaming/blob/323bb3245b4c5ab363abb673e4a928f222fce61b/src/playlist-loader.js#L590. But I caught the case when playlist.resolvedUri is undefined. This results in the xhr url being undefined.
https://<url>/undefined 404

I think it is necessary to add an additional condition that prevents this something like that

if (!playlist) {
     return this.media_;
  } else if (!playlist.resolvedUri) {
     return this.media_;
  }

Sources

https://github.com/videojs/http-streaming/blob/323bb3245b4c5ab363abb673e4a928f222fce61b/src/playlist-loader.js#L590

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

Start Live audio
observe logs in console

Results

There are errors 404 every some seconds. Audio stops playing after 20-30 seconds.

Expected

Audio should not stop playing and there should be no errors in the logs

Error output

https://<url>/undefined 404

Additional Information

Please include any additional information necessary here. Including the following:

videojs-http-streaming version

what version of videojs-http-streaming does this occur with? videojs-http-streaming last version

videojs version

what version of videojs does this occur with? video.js 7.18.1

Browsers

google chrome *

Platforms

Windows 11, MacOs 13.4.1 *

Other Plugins

are any other videojs plugins being used on the page? If so, please list them with version below. *

Other JavaScript

are you using any other javascript libraries or frameworks on the page? if so please list them below. *

welcome[bot] commented 10 months ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.