videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 419 forks source link

Custom data not coming in id3 metadata #1421

Open ezioda004 opened 10 months ago

ezioda004 commented 10 months ago

Description

Hi,

I'm appending timed metadata in an HLS output using AWS MediaLive service, I'm able to get the cuechange event on the TextTrack with correct timestamp of the data added, however the custom data is missing. ID3 frame being used in PRIV. If I use hls.js, I get this data in FRAG_PARSING_METADATA event. Is there anything similar in videojs where I can get the custom data?

The docs suggest we get this data in cue.value.data but cue.value is a Uint8Array which when converted to string is able to provide the timestamp but not the custom data.

I've also played around with settings like overrideNative but no luck.

Any help would be appreciated.

Sources

https://github.com/ezioda004/videojs-id3-files/blob/main/index.html I've added a basic html file with both version videojs and hls.js, with the required hls files in the above link.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. git clone
  2. npx http-server .
  3. open the local server from the previous command

Results

Expected

Expected to get custom ID3 data.

Error output

No errors.

Additional Information

Please include any additional information necessary here. Including the following:

videojs-http-streaming version

what version of videojs-http-streaming does this occur with? videojs-http-streaming x.y.z

videojs version

what version of videojs does this occur with? video.js 8.3.0

Browsers

Chrome Desktop, Safari Desktop

Platforms

what platforms are affected? please include operating system and version or device and version for each Tested on MacOS with Chrome and Safari

welcome[bot] commented 10 months ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

lastpeony commented 2 months ago

I have the same problem. did you find a fix? i can get the data with hls.js but not with videojs

ezioda004 commented 2 months ago

Videojs doesn’t support it, I ended up switching to hls.js.

lastpeony commented 2 months ago

@ezioda004 Hi thank you for your reply. @heff @ronhopper @makotokw any update regarding to such feature?