videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 418 forks source link

fix: content steering bug fixes and tests #1430

Closed adrums86 closed 8 months ago

adrums86 commented 9 months ago

Description

This PR addresses a few content steering bugs and ads some additional testing around live DASH.

Specific Changes proposed

Refactoring the content steering initialization to attach listeners separately, change some queryBeforeStart behavior and an issue with the initial ttl value.

Requirements Checklist

codecov[bot] commented 9 months ago

Codecov Report

Merging #1430 (5bb5282) into main (dd5e2af) will increase coverage by 0.07%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
+ Coverage   85.98%   86.06%   +0.07%     
==========================================
  Files          42       42              
  Lines       10428    10450      +22     
  Branches     2412     2416       +4     
==========================================
+ Hits         8967     8994      +27     
+ Misses       1461     1456       -5     
Files Coverage Δ
src/content-steering-controller.js 99.44% <100.00%> (+0.01%) :arrow_up:
src/dash-playlist-loader.js 90.51% <100.00%> (-0.03%) :arrow_down:
src/playlist-controller.js 96.00% <100.00%> (+0.19%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more