videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.53k stars 425 forks source link

fix: fmp4 captions regression #1434

Closed adrums86 closed 1 year ago

adrums86 commented 1 year ago

Description

Fixes an issue where caption data wasn't being passed out to the transmuxer callback for parsing.

Specific Changes proposed

Use the correctly scoped data object.

Requirements Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1434 (e127b7c) into main (dd5e2af) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   85.98%   85.98%           
=======================================
  Files          42       42           
  Lines       10428    10428           
  Branches     2412     2412           
=======================================
  Hits         8967     8967           
  Misses       1461     1461           
Files Coverage Δ
src/media-segment-request.js 96.11% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more