Closed pulsejet closed 1 year ago
π Thanks for opening this pull request! π
Things that will help get your PR across the finish line:
npm run lint -- --errors
locally to catch formatting errors earlier.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@adrums86
Merging #1439 (577f70d) into main (beccfa1) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #1439 +/- ##
=======================================
Coverage 85.94% 85.94%
=======================================
Files 42 42
Lines 10436 10436
Branches 2414 2415 +1
=======================================
Hits 8969 8969
Misses 1467 1467
Files | Coverage Ξ | |
---|---|---|
src/playlist-controller.js | 95.80% <100.00%> (ΓΈ) |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
Congrats on merging your first pull request! πππ
First of all thanks for the work you have been doing. We've been using video.js for some years and it's fantastic. Since we started using HLS we started to get some errors in sentry. I believe this commit fixes our issue. Can you please tell me when a new version will be released?
Thanks
IndexSizeError: Failed to execute 'end' on 'TimeRanges': The index provided (4294967295) is greater than the maximum bound (0).
at Mf.resetMainLoaderReplaceSegments (/public/frontend/_assets/videojs.2328859c5a34d65c05ea1c.js:181:38223)
This fixes a regression introduced in 4590bdd05aa2dd59bb2b60ce86daf453a093fba0
If the quality is changed during initialization, this function is called. Since
buffered.length
is zero andbuffered
is a TimeRanges,length
(anunsigned long
) wraps around and becomes4294967295