fix: use startTime instead of 0 for finiteDuration

videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js

https://videojs-http-streaming.netlify.app/

Other

2.45k stars 418 forks source link

fix: use startTime instead of 0 for finiteDuration #1448

Closed adrums86 closed 7 months ago

adrums86 commented 7 months ago

Description

We shouldn't set endTime to 0, instead we should set it to the startTime if we don't have a duration.

Specific Changes proposed

replace 0 with startTime

Requirements Checklist

[ ] Feature implemented / Bug fixed
[ ] If necessary, more likely in a feature request than a bug fix
- [ ] Unit Tests updated or fixed
- [ ] Docs/guides updated
- [ ] Example created (starter template on JSBin)
[ ] Reviewed by Two Core Contributors

adrums86 commented 7 months ago

@dzianis-dashkevich a fix from a while ago that you brought to my attention re #1411.

robert-schurig-mi commented 6 months ago

With "@videojs/http-streaming": "3.0.2" the cues worked as expected and they get active because the endTime was set to Infinity.

Then the endTime of a cue was set to "0" and the stoped working, they don't get active and not event dispatch.

Now in the latest version "@videojs/http-streaming": "3.8.0" the endTime is set to the startTime... okay. sounds for me like an improvement... but the cue doesn't get active too. So what does it fix ?