search

videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.49k stars 421 forks source link

feat: Add experimental support for ManagedMediaSource #1453

Closed mister-ben closed 1 month ago

mister-ben commented 10 months ago

Adds basic support for ManagedMediaSource. Must be enabled with the useManagedMediaSource VHS option.

Does not implement an alternate AirPlay source - this requires a more significant change, to add two source els. This means remote playback has to be disabled on the video el when using MMS.

Event listeners for advanced control are not yet implemented - startstreaming, endstreaming, qualitychange

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.36%. Comparing base (dba1b79) to head (f700a8e). Report is 1 commits behind head on main.

Files Patch % Lines
src/videojs-http-streaming.js 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1453 +/- ## ========================================== - Coverage 86.36% 86.36% -0.01% ========================================== Files 43 43 Lines 11144 11151 +7 Branches 2545 2548 +3 ========================================== + Hits 9625 9631 +6 - Misses 1519 1520 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mister-ben commented 10 months ago

Adding as <source> children instead of the src attribute could be done here. We would need to ensure both the attribute and <source> children are removed on source changes, including to or from non-VHS sources. Also, will anything else expect the src attribute to be present?

snowinszu commented 3 months ago

Hi, any news?