videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 418 forks source link

fix: remove replaceSegmentsUntil #1455

Closed adrums86 closed 7 months ago

adrums86 commented 7 months ago

Description

In order to reduce complexity when changing renditions, lets remove replaceSegmentsUntil and simply pause, reset then load all the segment loaders when doing a fastQualityChange.

Specific Changes proposed

remove replaceSegmentsUntil and replace with a simpler quality change mechanism.

Requirements Checklist

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b4dd748) 86.14% compared to head (fbfcc0c) 86.14%.

Files Patch % Lines
src/playlist-controller.js 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1455 +/- ## ======================================= Coverage 86.14% 86.14% ======================================= Files 42 42 Lines 10624 10613 -11 Branches 2449 2446 -3 ======================================= - Hits 9152 9143 -9 + Misses 1472 1470 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dzianis-dashkevich commented 7 months ago

I think we can close this one in favor of this one: https://github.com/videojs/http-streaming/pull/1457

adrums86 commented 7 months ago

Closing this and reverting the original commit in #1457 instead.