fix: remove replaceSegmentsUntil

videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js

https://videojs-http-streaming.netlify.app/

Other

2.53k stars 425 forks source link

fix: remove replaceSegmentsUntil #1455

Closed adrums86 closed 12 months ago

adrums86 commented 12 months ago

Description

In order to reduce complexity when changing renditions, lets remove replaceSegmentsUntil and simply pause, reset then load all the segment loaders when doing a fastQualityChange.

Specific Changes proposed

remove replaceSegmentsUntil and replace with a simpler quality change mechanism.

Requirements Checklist

[x] Feature implemented / Bug fixed
[ ] If necessary, more likely in a feature request than a bug fix
- [ ] Unit Tests updated or fixed
- [ ] Docs/guides updated
- [ ] Example created (starter template on JSBin)
[ ] Reviewed by Two Core Contributors

codecov[bot] commented 12 months ago

Files	Patch %	Lines
src/playlist-controller.js	90.00%	1 Missing :warning:

```diff @@ Coverage Diff @@ ## main #1455 +/- ## ======================================= Coverage 86.14% 86.14% ======================================= Files 42 42 Lines 10624 10613 -11 Branches 2449 2446 -3 ======================================= - Hits 9152 9143 -9 + Misses 1472 1470 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dzianis-dashkevich commented 12 months ago

I think we can close this one in favor of this one: https://github.com/videojs/http-streaming/pull/1457