videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 418 forks source link

fix: currentMediaInfo undefined causing buffer change #1462

Closed adrums86 closed 6 months ago

adrums86 commented 6 months ago

Description

currentMediaInfo_ is becoming undefined due to a change in playlists from ABR, this is eventually causing a call to addOrChangeSourceBuffers via a trackinfo event which will throw an error trying to change the source buffer unnecessarily.

Specific Changes proposed

check if currentMediaInfo_ is defined before comparing to the trackInfo.

Requirements Checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c726760) 86.01% compared to head (46bb7e6) 85.91%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1462 +/- ## ========================================== - Coverage 86.01% 85.91% -0.10% ========================================== Files 42 42 Lines 10673 10672 -1 Branches 2456 2456 ========================================== - Hits 9180 9169 -11 - Misses 1493 1503 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adrums86 commented 6 months ago

Closing this as it didn't turn out to be the correct solution.