videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 418 forks source link

fix: toLowerCase keyIds from manifest and use fastQualityChange #1466

Closed adrums86 closed 6 months ago

adrums86 commented 6 months ago

Description

Manifests with uppercase keyIds were not matching with keyIds coming from the MediaKeyStatusMap. Also occasionally we would buffer encrypted content that we may not have a key for, we need to call fastQualityChange to clear the buffer before switching playlists.

Specific Changes proposed

Add toLowerCase to the keyId from the manifest when passing the keyIdSet for playlist filtering and call fastQualityChange instead of switchMedia then fix tests.

Requirements Checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2878b27) 86.03% compared to head (533e821) 86.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1466 +/- ## ========================================== - Coverage 86.03% 86.02% -0.01% ========================================== Files 42 42 Lines 10712 10708 -4 Branches 2462 2461 -1 ========================================== - Hits 9216 9212 -4 Misses 1496 1496 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.