Closed dzianis-dashkevich closed 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f12c197
) 86.05% compared to head (72e5c05
) 86.05%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
we should account for the difference between the duration info in the manifest and the actual duration of the segment when selecting next segment after quality change.
Assume we have the following playlist:
Assume we already appended two segments, so
bufferend.end
should be20
, but we don't have an exact duration match between the playlist and the actual segment duration, so we receive it as19.99999..
. Currently, we select segment-2.ts instead of segment-3.ts because we do not account for this timestamp fluctuation.Specific Changes proposed
Check whether we hit timestamp fluctuation by adding
TIME_FUDGE_FACTOR
(1 / 30).Requirements Checklist