Closed dzianis-dashkevich closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5b87f69
) 86.06% compared to head (3d04436
) 87.13%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
We may encounter duplicate segment loading during bandwidth updates. Since we are re-calculating timestampOffset during each quality switch it results in presenting of duplicate segments.
Consider the following situation:
This log is placed in the
chooseNextRequest_
. As you can see:Specific Changes proposed
Make an assumption that some segment or segment's part is already buffered if the difference between segment.end and buffered.end is less or equal to 2 * TIME_FUDGE_FACTOR (which is 0.06) Fallback by selecting the next part or segment using buffered.end + difference padding.
Requirements Checklist