videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.45k stars 416 forks source link

fix: lockfile integrity #1504

Closed adrums86 closed 2 months ago

adrums86 commented 2 months ago

Description

npm install

Specific Changes proposed

ran install and the lockfile needed an update

Requirements Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.28%. Comparing base (e4acc57) to head (33b5218).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1504 +/- ## ======================================= Coverage 86.27% 86.28% ======================================= Files 43 43 Lines 10886 10886 Branches 2506 2506 ======================================= + Hits 9392 9393 +1 + Misses 1494 1493 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wseymour15 commented 2 months ago

Isn't SHA512 the more secure algorithm? I wonder why these dependencies are changing to a less secure hash.

gkatsev commented 2 months ago

I assume it's a npm version mismatch between the one that was last used to generate, and then the one used here. We've historically only used the npm version that ships with the node version specified in the nvmrc. If a newer version of npm was used, everyone else should update to use that version of npm because otherwise there'll be lots of thrashing of the package-lock file.

adrums86 commented 2 months ago

Yeah this was the result of an npm install with node v14.21.3 I noticed during a previous release, the nvmrc has 14 as well 🤷‍♂️ . Closing for now, we can sort this out later.