videojs / http-streaming

HLS, DASH, and future HTTP streaming protocols library for video.js
https://videojs-http-streaming.netlify.app/
Other
2.5k stars 422 forks source link

Support for EXT-X-START in HLS #310

Closed jimmycallin closed 6 months ago

jimmycallin commented 5 years ago

Hi!

I noticed that video.js doesn't seem to respect EXT-X-START as set in my HLS manifest, e.g:

#EXT-X-START:TIME-OFFSET=0.7,PRECISE=YES

I also noticed there is an abandonded(?) PR by @masterful in videojs-contrib-hls: https://github.com/videojs/videojs-contrib-hls/pull/1299

Is this indeed something that this library doesn't currently support? If possible, I would very much appreciate if it could be a part of your roadmap.

welcome[bot] commented 5 years ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

masterful commented 5 years ago

👋 hi @jimmycallin - I believe I updated the PR as requested - but I never did figure out what was causing the tests to fail... I can revisit the PR once I understand what's failing 🤷‍♂️

jimmycallin commented 5 years ago

@masterful That would be great! Perhaps a first step could be to migrate it to this new repo? :)

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jimmycallin commented 5 years ago

I would like if this wasn't closed.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jimmycallin commented 5 years ago

Still interested

meikidd commented 5 years ago

interested +1

Hayko-1 commented 5 years ago

interested +1

shay-sundaysky commented 5 years ago

+1

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gkatsev commented 4 years ago

Oops, yeah, we should have support for this.

saurabhkhandelwal commented 4 years ago

Guys any idea when this might go live, would be of great help. Thanks in advance.

vegetablesalad commented 4 years ago

Really need this. Otherwise have to parse m3u8 file and skip in code.

saurabhkhandelwal commented 4 years ago

@vegetablesalad I did a hack for this, implemented another field as an offset in the API in which I get the stream URL, and then on video meta load I just call this currentTime(offset).

abdul-hamid-achik commented 3 years ago

guys this seems to be supported already but I could be wrong or misunderstanding this issue, if i run: player.tech().vhs.selectPlaylist() I do se the EXT-X-START params that we are settings being parsed

Screen Shot 2021-08-10 at 13 31 18 Screen Shot 2021-08-10 at 13 30 35

gkatsev commented 3 years ago

While it gets parsed, I'm pretty sure we don't currently use it at all.

abdul-hamid-achik commented 3 years ago

While it gets parsed, I'm pretty sure we don't currently use it at all.

@gkatsev thanks for answering so fast then ill just do the same thing as @saurabhkhandelwal

You2499 commented 2 years ago

Any update on this? Looked for hours only to find out it's not supported xD

blokfyuh commented 2 years ago

+1

ohIcee commented 6 months ago

+1

mister-ben commented 6 months ago

This was released in http-streaming v3.3.0, in Video.js 8.4.0+

https://github.com/videojs/http-streaming/blob/main/CHANGELOG.md#330-2023-05-03