search

videojs / m3u8-parser

An m3u8 parser.
Other
471 stars 98 forks source link

feat: improve parsing for a frame-rate attribute #150

Closed gjanblaszczyk closed 2 years ago

gjanblaszczyk commented 2 years ago

The 'FRAME-RATE' attribute should be a floating-point number type rather than a string.

gjanblaszczyk commented 2 years ago

The PR is related to this https://github.com/videojs/mpd-parser/pull/159

gesinger commented 2 years ago

This looks good @gjanblaszczyk , thank you. The only concern I have is that it technically breaks the old output. Although it should be minor, and is more appropriate as a number, we should consider a small major for this.

gjanblaszczyk commented 2 years ago

Thanks for the feedback @gesinger. @gkatsev any thoughts?

gkatsev commented 2 years ago

Yeah, technically a breaking change. Don't see a problem with making a major version of m3u8-parser, though.

gjanblaszczyk commented 2 years ago

@gkatsev Is it enough to add this footer message during GitHub squash and merge action? or maybe I should do something more...

gkatsev commented 2 years ago

yup, that would do it. I rarely if ever merge locally anymore and we prefer squash+merge in the video.js projects.