videojs / monorepo

Monorepo for all videojs packages
https://videojsdev.netlify.app/
Other
7 stars 0 forks source link

camel case file names #27

Closed gkatsev closed 2 months ago

gkatsev commented 2 months ago

I noticed that a lot of files have camel case naming like networkManager.ts. It might be better to switch to kebab case for filenames (like network-mananger.ts). The main issue is that macos's file system is generally case-insensitive but other filesystems are generally case-sensitive. Keeping all file names all lowercase will minimize the risk of potentialy issues working cross-os.

dzianis-dashkevich commented 2 months ago

Hi, @gkatsev. Thanks for reporting this issue. I guess it should not be a problem. Packages will fail to build (even on Mac) if the exact filename does not match

gkatsev commented 2 months ago

It isn't a huge issue, but it's very common for file names to be kebab-cased, so, it's weird seeing camelCased files.

Essk commented 2 months ago

Peculiarities of file name casing have definitely cost me some head-scratching time in the past. I'm guessing I'm not alone in that so I'd see changing to kebab-case as a great way to lower friction in general.

dzianis-dashkevich commented 2 months ago

I am not sure the kebab case is more popular... Here is a bunch of camelCase/pascalCase examples:

I came from the Java world and got used to Pascal's case. When I transitioned to JS, I just started using camelCase by default.

Anyway, I will add the kebab ESlint rule and update filenames

dzianis-dashkevich commented 2 months ago

Fixed: https://github.com/videojs/monorepo/pull/29

gkatsev commented 2 months ago

Thanks!