If label is set used this in the subtitle menu display or default to language.

videojs / mpd-parser

https://videojs.github.io/mpd-parser/

Other

79 stars 54 forks source link

If label is set used this in the subtitle menu display or default to language. #153

Closed s3bubble closed 2 years ago

s3bubble commented 3 years ago

Currently when setting subtitles in DASH it uses the lang attribute by default.

It should use the label attribute if it is set in the manifest.

Example of issue here. https://jsbin.com/rinemex/edit?html,output

Relating to this issue. https://github.com/videojs/video.js/issues/7525

gkatsev commented 3 years ago

Thanks for the PR. Looking at the DASH spec, this label attribute doesn't seem standard. It seems like the standard way is to have a Label element inside the AdaptationSet rather than a label attribute on the AdaptationSet element. Your example is actually the first DASH example that I've seen labelling caption tracks. We'd have to consider whether we want to support something that isn't standard to the spec.