videojs / mpd-parser

https://videojs.github.io/mpd-parser/
Other
78 stars 54 forks source link

fix: get event tag content #171

Closed adrums86 closed 1 year ago

adrums86 commented 1 year ago

fixes Event node parsing to account for <Event> node content first, then messageData. See: https://dashif-documents.azurewebsites.net/Events/master/event.html#mpd-event-timing

@messageData O specifies the value for the event stream element. The value space and semantics must be defined by the owners of the scheme identified in the @schemeIdUri attribute. NOTE: the use of the message data is discouraged by content authors, it is only maintained for the purpose of backward-compatibility. Including the message in the Event element is recommended in preference to using this attribute. This attribute is expected to be deprecated in the future editions of this document.
codecov[bot] commented 1 year ago

Codecov Report

Merging #171 (ed7a1d7) into main (9272af3) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   94.57%   94.58%           
=======================================
  Files          19       19           
  Lines         811      812    +1     
  Branches      246      247    +1     
=======================================
+ Hits          767      768    +1     
  Misses         44       44           
Impacted Files Coverage Δ
src/inheritAttributes.js 97.56% <100.00%> (+0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more