search

videojs / mpd-parser

https://videojs.github.io/mpd-parser/
Other
79 stars 54 forks source link

fix: ensure vtt tracks language is set correctly #181

Closed wseymour15 closed 1 month ago

wseymour15 commented 1 month ago

Description

In DASH, the language property we set on VTT tracks should be accurate. As of now, this value is the label when it exists, THEN the language.

This change sets the language to the lang property if it exists, then the label, and then en by default.

gkatsev commented 1 month ago

Just thought about it, and the change of the default from text to und is potentially a breaking change. Though, given that the language previously didn't make any sense, I think we should proceed anyway and call it a soft breakage. If it breaks anyone, we can then revert it for v4 and do a major version bump.

wseymour15 commented 1 month ago

Just thought about it, and the change of the default from text to und is potentially a breaking change. Though, given that the language previously didn't make any sense, I think we should proceed anyway and call it a soft breakage. If it breaks anyone, we can then revert it for v4 and do a major version bump.

Totally agree. It seems unlikely people are using a language value of text for anything, but I agree with moving forward and then bumping afterwards worst case.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.68%. Comparing base (5ea10f5) to head (8688dcd). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ======================================= Coverage 94.68% 94.68% ======================================= Files 19 19 Lines 846 847 +1 Branches 258 259 +1 ======================================= + Hits 801 802 +1 Misses 45 45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.