search

videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
38.19k stars 7.47k forks source link

With popcorn.js? #1034

Closed binarykitchen closed 10 years ago

binarykitchen commented 10 years ago

Hello guys

Has anyone of you experience in combining video.js with popcorn.js from Mozilla?

http://popcornjs.org/ looks nice and has lots of useful features. But I see that some of these are already implemented in video.js ...

Opinions welcome!

gkatsev commented 10 years ago

popcornjs is made specifically to play videos as well as give hooks for the plugin system. Videojs itself already plays videos. Though, it may be possible and not a bad idea to create a videojs plugin that allows popcornjs plugins to work with videojs.

imbcmdth commented 10 years ago

it may be possible and not a bad idea to create a videojs plugin that allows popcornjs plugins to work with videojs.

Popcorn plugins depend on a Popcorn global being specified. Popcorn isn't written with any sort of module system and depends on either the plugin being bundled during build with popcorn or added via a <script>.

gkatsev commented 10 years ago

Maybe what's needed is the opposite: popcornjs plugin that integrates videojs.

cladera commented 10 years ago

Take a look to plugin https://github.com/cladera/videojs-cuepoints. It might be a beginning...

heff commented 10 years ago

I think what would be needed is a Popcorn Player implementation, like these examples: http://popcornjs.org/popcorn-docs/players/

I'm not sure what it'd take, but might not be too hard working off one of those examples.

I'm going to label as plugin and close the issue since it doesn't involve updates to video.js core, but let's continue the conversation.

binarykitchen commented 10 years ago

If you ever do a player, please highly configurable and without CSS. And with modern HTML5 markup.

hdn8 commented 10 years ago

There's a JWPlayer wrapper now, should be able to follow that example for video-js: https://github.com/mozilla/popcorn-js/tree/master/wrappers/jwplayer

heff commented 10 years ago

@hdn8 do you want to give it a shot?

hdn8 commented 10 years ago

I'm looking into it, let you know if I think I can manage it. Should note that in HTML5 mode it works out of the box however just by wrapping popcorn on the video object http://jsfiddle.net/vCQEN/2746/. For flash mode though would have to make a video tag wrapper around the flash object, as the JWPlayer wrapper does: "making the flash object masquerade as HTML 5 video"

heff commented 10 years ago

@hdn8, ideally an integration between video.js and popcorn.js would only use the video.js API. Then that would allow it to work with all the playback techs that video.js supports, currently including youtube and vimeo.

hdn8 commented 10 years ago

Ok agreed, from what Ive seen so far building a popcorn media wrapper for video-js would be use the popcorn constructor to inject an instance of the video-js player and allow access to it the video-js API, which would also allow use and definition of the playback techs. In the coming weeks I may take a stab at it, will post here if so.

On Fri, Jul 11, 2014 at 8:46 PM, Steve Heffernan notifications@github.com wrote:

@hdn8 https://github.com/hdn8, ideally an integration between video.js and popcorn.js would only use the video.js API. Then that would allow it to work with all the playback techs that video.js supports, currently including youtube and vimeo.

— Reply to this email directly or view it on GitHub https://github.com/videojs/video.js/issues/1034#issuecomment-48768053.