search

videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
38.1k stars 7.45k forks source link

Subtitles {\pos(x,y)} #1305

Closed ghost closed 10 years ago

ghost commented 10 years ago

Using videojs 4.6.1 capture

As you can see up there, the pos(x,y) parameter for SRT files is not used in videojs.

VLC makes abstraction of { } by just non displaying the content. Couldn't we also do that ?

mmcc commented 10 years ago

We only officially support VTT text tracks, so there isn't going to be much (if any) work done to further SRT support. However, if all you'd like to do is ignore bracket declarations, that would be pretty straight forward to do. Would you be interested in submitting a pull request for this? If you'd like to take SRT support further, I think that's probably better suited for a plugin (which would also be awesome).

I'm going to close this since, but again, a PR and / or plugin to address this would absolutely be welcome.