videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
37.82k stars 7.43k forks source link

controlBar.currentTimeDisplay does not apply. #5751

Open yangtaeho opened 5 years ago

yangtaeho commented 5 years ago

Description

Briefly describe the issue. Include a reduced test case, we have a starter template on JSBin you can use.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. option ---> { controlBar: { currentTimeDisplay: true } } does not apply.
  2. option ---> { controlBar: { remainingTimeDisplay: false, currentTimeDisplay: true } } does not apply.

Results

Expected

Please describe what you expected to see. off remainingTimeDisplay, on currentTimeDisplay

Actual

Please describe what actually happened.

  1. option ---> { controlBar: { currentTimeDisplay: true } } on remainingTimeDisplay
  2. option ---> { controlBar: { remainingTimeDisplay: false, currentTimeDisplay: true } } just off remainingTimeDisplay

Error output

If there are any errors at all, please include them here.

Additional Information

Please include any additional information necessary here. Including the following: This library is very useful. thank you.

versions

videojs

what version of videojs does this occur with? 7.1.0

browsers

what browser are affected? chrome and ie11

OSes

what platforms (operating systems and devices) are affected? Windows 10

plugins

are any videojs plugins being used on the page? If so, please list them below.

welcome[bot] commented 5 years ago

šŸ‘‹ Thanks for opening your first issue here! šŸ‘‹

If you're reporting a šŸž bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

mister-ben commented 5 years ago

The control is present by default, but hidden by CSS. This would unhide it.

.video-js .vjs-current-time { display: block; }
stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SpanishOnion commented 5 years ago

+1, How did you solve it? I'll settle this for the time being: `
.video-js .vjs-current-time, .vjs-no-flex .vjs-current-time { display: block !important; }

.vjs-time-divider {
    display: block !important;
}

.video-js .vjs-duration, .vjs-no-flex .vjs-duration {
    display: block !important;
}`
etomProductions commented 3 years ago

@mister-ben Thank you for this advise. If it should be set manually, no need to have it as option. Unless there is other way to toggle it out.

gkatsev commented 3 years ago

This is probably something that we should handle but it keeps not happening. Video.js should auto display those controls if explicitly enabled in options.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fguillen commented 11 months ago

Looking forward to being able to display CurrentTimeDisplay in an easy way that doesn't look like I am hacking DOM elements' visibility by custom CSS.