videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
37.5k stars 7.4k forks source link

Building Components with Plugin #6596

Closed abprojects closed 3 years ago

abprojects commented 4 years ago

I've run into a bug trying to get the rangeslider plugin to work with videojs. (Found here https://github.com/danielcebrian/rangeslider-videojs). I am aware that the author doesn't maintain the plugin anymore, but am trying to get it to work. I've also followed some of the compiler issues mentioned in #2016, #2578, and followed the thread on the switch to Uglify. I've used the developer version to avoid those issues, but still get the same error thrown.

The error that's thrown is this: Screenshot_2020-04-15_12-00-17

The component is loaded onto the player via this: rs_2020-04-15_12-00-17

When I inspect the player component, I can see RSTimeBar (the source of where the error is thrown) loaded in the array for options_.children of seekbar, but it is not loaded under seekbar.children: console_2020-04-15_12-35-23

I've run out of ideas. Could someone point me in the right direction on this?

Thanks!

welcome[bot] commented 4 years ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gkatsev commented 4 years ago

Are you trying to add this component as a child of the seek bar at runtime? If so, you generally want to use addChild. I would also advise against modifying pseudo-private (suffixed with _) properties.

player.controlBar.addChild('controlTimePanel');
stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.