search

videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
38.11k stars 7.46k forks source link

Disable preload spinner? #669

Closed davidgeorgehill closed 11 years ago

davidgeorgehill commented 11 years ago

Is it possible to easily disable the pre-load spinner? It hangs on some browsers and continues to spin even after the video begins. Thanks.

heff commented 11 years ago

You can kill the component completely through an option setting. videojs.options.children.loadingSpinner = false; or var myPlayer = videojs('id', { children: { loadingSpinner: false }});

Which browsers, and is there a live example somewhere?

davidgeorgehill commented 11 years ago

Thank you so much for your reply ... yes, here is example: =20 http://pricklypearjunction.com ... it is the "Farmers' Market" video =20 with the tomato ... odd, it does not happen on my Windows XP computer, =20 but it does on both of my Windows 7 computers ... make sure to clear =20 cache ... it does not happen in IE, or Safari but does happen =20 consistently in newest Firefox ... spinner keeps going after it starts =20 and then goes away after the first "loop" ... by the way, could you be =20 more specific about how to disable? I am not that well versed in code. =20 Not sure exactly where would I change that code? By the way, that will =20 make this video perfect! Your component is fabulous. dgh

davidgeorgehill commented 11 years ago

Thank you so much for your reply ... yes, here is example: =20 http://pricklypearjunction.com ... it is the "Farmers' Market" video =20 with the tomato ... odd, it does not happen on my Windows XP computer, =20 but it does on both of my Windows 7 computers ... make sure to clear =20 cache ... it does not happen in IE, or Safari but does happen =20 consistently in newest Firefox ... spinner keeps going after it starts =20 and then goes away after the first "loop" ... by the way, could you be =20 more specific about how to disable? I am not that well versed in code. =20 Not sure exactly where would I change that code? By the way, that will =20 make this video perfect! Your component is fabulous. dgh

:::::::::: David Hill :: Developer of: Prickly Pear Junction "Cloud" http://pricklypearjunction.com Phone: 422.4033 Cell: 431.6026

davidgeorgehill commented 11 years ago

I am not sure where all of those =20 are coming from in my previous messages, but in case it makes the message a bit unclear: the spinner only acts up in Firefox and only on Windows 7 ... I have a Windows XP with Firefox and it works flawlessly. Also, even on Windows 7 machines, Safari, Chrome and IE it works perfectly. Only seems to be a problem on Firefox/Windows 7 ... and I cannot figure out where to enter either of the disable codes you sent ... thanks very much for your help. dgh

davidgeorgehill commented 11 years ago

I assume you guys are extraordinarily busy, but I would sure appreciate knowing exactly which files those codes go into ... and where to enter them. I would like to finalize that site. Thanks again. dgh

mmcc commented 11 years ago

I assume you're talking about Heff's suggestions on how to disable the spinner? If so, the easiest way to go about it is going to be to include his suggestion in the data-setup attribute.

<video id="example_video_id_209127149" class="video-js vjs-default-skin" width="335" height="250" preload="none" autoplay loop data-setup='{"children": {"loadingSpinner": false}}'>
    <source src="farm.mp4" type='video/mp4' />
</video>
davidgeorgehill commented 11 years ago

Thanks very much ... an odd thing happens when I paste this into my WordPress page ... I get this terribly long code after I save and it looks like it includes an SWF player instead of videojs player ... any idea what is happening? Here is the code which appears after I save:

davidgeorgehill commented 11 years ago

Looks like it will not let me enter the code, but it is very, very long. Your help is appreciated. Is there not a place I can enter code directly into a file in the videojs plugin folder on WordPress? Thanks.

davidgeorgehill commented 11 years ago

Matthew, please be clear, I very much appreciate your help. The one thing that concerns me is the huge amount of code that is added after I paste your code into a WordPress page and then save. Here is a text file with the added code: (I tried entering it here yesterday but it was apparently not allowed) http://pricklypearjunction.com/addedCode.txt ... if there is a way to disable the spinner wherein I can still use the Video.js short code, that would be preferable I think. See your version here (by the way, it does disable the spinner!) http://www.pricklypearjunction.com/?page_id=3757 ... thanks again for your efforts. dgh.

mmcc commented 11 years ago

Ah I didn't realize you were using a wordpress plugin. The extra code you see when you paste in what I gave you is a Flash player unrelated to Video.js (Moxieplayer). I haven't used the wordpress plugin, but after a brief look at the source it doesn't look like you can pass anything to the data-setup attribute via a short code.

  1. Paste the code sample I gave you as raw HTML instead of through the WYSIWYG editor.
  2. Use the original shortcode you had and put this code from Steve in your source some time after the Video.js include:
<script>
    videojs.options.children.loadingSpinner = false;
</script>
davidgeorgehill commented 11 years ago

Clearly I am doing something wrong: using your code and entering it with the WordPress HTML button, I still get that extra code. And I prefer the shortcode but am not able to figure out where to put your "script" code. Feeling a bit dumb right now. Any other suggestions? Thanks so much.

heff commented 11 years ago

Closing this as a video.js issue since it's turned to wordpress. Feel free to continue the discussion.

mmcc commented 11 years ago

Sorry I'm not much help with the WordPress side of things and have no idea what you're seeing when it comes to the extra code, but you can put that <script> tag from option 2 anywhere in the page after Video.js has been loaded. If you want to disable the spinner for all instances of Video.js, I would suggest editing your theme layout.

davidgeorgehill commented 11 years ago

You have been great. I had no idea it was going to be such a challenge. The only reason it is an issue at all is that it is a fairly short video loop and on some browsers the spinner keeps going through one full loop ... it is distracting. Again, thank you very much for your efforts. dgh

davidgeorgehill commented 11 years ago

Believe it or not, option 2 script did it! It works flawlessly now. My hope is that anyone else using WordPress 3.6 with a similar challenge can use this exchange. As I said, it is a fairly short video loop and so the spinner was just not necessary. I cannot possibly thank you enough.

mmcc commented 11 years ago

Excellent! Glad I could help.

hlolli commented 6 years ago

By adding data-setup='{"children": {"loadingSpinner": false}}' I get

TypeError: Cannot read property 'on' of undefined and then something about qualityPickerPlugin, guess this doesn't merge the json maps but overwrites it.

Not really a question, just in case someone drops by this issue and has a similar problem and a solution...

FossPrime commented 5 years ago

The spinner behavior is different on chrome/safari than ff... if a caption is empty or missing, it will get stuck spinning :/

Seems like my subtitle source should default to null, not '' an empty string. This confused firefox.