search

videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
38.09k stars 7.45k forks source link

CSS is using deprecated selector :lang() #7432

Closed SammyDodgerr closed 2 years ago

SammyDodgerr commented 3 years ago

Description

CSS is using depreciated selector :lang(), printing some warnings to anyone with the latest version of angular.

Steps to reproduce

  1. npm i latest version (7.15.4)
  2. update angular to latest version (12)
  3. ng serve and watch the terminal

Results

Expected

To see no warnings.

Actual

See multiple warnings: 

.video-js.video-js:lang(en-AU) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js.video-js:lang(en-GB) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js.video-js:lang(en-IE) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js.video-js:lang(en-NZ) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js.video-js:lang(en-AU) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js.video-js:lang(en-GB) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js.video-js:lang(en-IE) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js.video-js:lang(en-NZ) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js:lang(en) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js:lang(fr-CA) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js:lang(en) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang
  .video-js:lang(fr-CA) .vjs-subs-caps-button .vjs-icon-placeholder -> unmatched pseudo-class :lang

Additional Information

videojs version

7.15.4

browsers

chrome

welcome[bot] commented 3 years ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

mister-ben commented 3 years ago

:lang() isn't deprecated. Angular had an issue with some pseudo classes, but that's supposed to have been fixed: https://github.com/angular/angular-cli/issues/20031

abierbaum commented 3 years ago

@SammyDodgerr Did you find a way around this?

SammyDodgerr commented 3 years ago

@abierbaum the errors stopped showing for me... I would just make sure all your libraries are up to date and try again

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.