search

videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
37.91k stars 7.43k forks source link

public, 'current' version tag: v7 or v8 #8112

Closed peterblazejewicz closed 1 year ago

peterblazejewicz commented 1 year ago

Hi,

not a code issue:

This is for maintainers of the repo. I'd like to create a PR against Definitely Typed repository to deprecated v7 of @types/video.js and to redirect types acquisition for @latest version against current NPM registry. But I have a doubt, as the repository lists v8 recent releases as prerelease, while NPM registry lists 8.0.4 version as both latest and next versions. npm pack seems to confirm v8 is latest version, non-prerelease. https://www.npmjs.com/package/video.js?activeTab=versions https://unpkg.com/browse/video.js@8.0.4/dist/types/video.d.ts

As the results, the v8 will be picked as the version suggested by automatic type acquisition feature in TS (VS/VSCode,etc), unless the entry in package.json suggests v7 (or older)

Thanks!

video-archivist-bot commented 1 year ago

Hey! We've detected some video files in a comment on this issue. If you'd like to permanently archive these videos and tie them to this project, a maintainer of the project can reply to this issue with the following commands:

welcome[bot] commented 1 year ago

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

gkatsev commented 1 year ago

The npm tags tend to be more up-to-date compared to the github tags. We don't tend to clear out the next tag when promoting to latest on npm, though.

The DT types do work for Video.js v7 and older, though. But deprecating it for v8 sounds fine. Though, probably fix some things like https://github.com/videojs/video.js/issues/8109 before this is deprecated.

peterblazejewicz commented 1 year ago

@gkatsev thanks! subscribed to 8109, thanks!

wseymour15 commented 1 year ago

Closing this as it seems to be resolved and being tracked in another issue. Please re-open if needed.