videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
38.11k stars 7.46k forks source link

Time display for player causes prevention role conflict accessibility issue #8143

Open bwood614 opened 1 year ago

bwood614 commented 1 year ago

Description

The time display elements in the player have an accessibility issue. The elements within the various time display elements (e.g. spans with classes like vjs-current-time-display, vjs-duration-display, vjs-remaining-time-display, etc.) have the attributes role="presentation" and aria-live="off". It looks like role="presentation" was added some time after the aria-live attribute and the aria-live attribute was never removed.

Having global aria attributes and role="presentation" in the same element is redundant and can lead to some unexpected behaviors across browsers. See https://dequeuniversity.com/rules/axe/4.1/presentation-role-conflict for more information about this issue.

Reduced test case

No response

Steps to reproduce

  1. Inspect the time display element(s) in the player with browser dev tools

Errors

No response

What version of Video.js are you using?

8.0.4

Video.js plugins used.

None

What browser(s) including version(s) does this occur with?

Chrome 109

What OS(es) and version(s) does this occur with?

Mac OS Monterey v12.4

welcome[bot] commented 1 year ago

πŸ‘‹ Thanks for opening your first issue here! πŸ‘‹

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

brayden-wood commented 1 year ago

I am picking up this issue and submitting a PR for it