videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
38.12k stars 7.46k forks source link

Sass deprecations for global built-in functions #8909

Open rtritto opened 1 week ago

rtritto commented 1 week ago

Description

After I updated sass-embedded to version 1.80.0:

Changes

@import is now officially deprecated, as are global built-in functions that are available within built-in modules. See the Sass blog post for more details on the deprecation process.

Output

Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.        

More info: https://sass-lang.com/d/legacy-js-api

---

Deprecation Warning on line 2, column 6 of file:///C:/<PROJECT_PATH>/node_modules/videojs-font/scss/_icons.scss:2:6:
Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use meta.function-exists instead.

More info and automated migrator: https://sass-lang.com/d/import

2 |   @if function-exists("selector-append") {

C:\<PROJECT_PATH>\node_modules\videojs-font\scss\_icons.scss 3:7    char()
C:\<PROJECT_PATH>\node_modules\videojs-font\scss\_icons.scss 91:16  @import
C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 6:9      @import
scss\videojs.scss 2:9                                                                      
                                                   root stylesheet

---

Deprecation Warning on line 3, column 12 of file:///C:/<PROJECT_PATH>/node_modules/videojs-font/scss/_icons.scss:3:12:
Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.unquote instead.

More info and automated migrator: https://sass-lang.com/d/import

3 |     @return unquote("\"\\#{$character-code}\"");

C:\<PROJECT_PATH>\node_modules\videojs-font\scss\_icons.scss 4:13   char()
C:\<PROJECT_PATH>\node_modules\videojs-font\scss\_icons.scss 91:16  @import
C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 6:9      @import
scss\videojs.scss 2:9                                                                      
                                                   root stylesheet

---

Deprecation Warning on line 8, column 29 of file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/_private-variables.scss:8:29:
Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.

More info and automated migrator: https://sass-lang.com/d/import

8 | $secondary-background-color: lighten($primary-background-color, 33%) !default;

C:\<PROJECT_PATH>\node_modules\video.js\src\css\_private-variables.scss 9:30  @import
C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 3:9             @import
scss\videojs.scss 2:9                                                                      
                                                          root stylesheet

---

Deprecation Warning on line 29, column 17 of file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/utilities/_linear-gradient.scss:29:17:
Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use list.index instead.

More info and automated migrator: https://sass-lang.com/d/import

29 |   $is-direction: index((
    'to top',
    'to top right',
    'to right top',
    'to right',
    'to bottom right',
    'to right bottom',
    'to bottom',
    'to bottom left',
    'to left bottom',
    'to left',
    'to left top',
    'to top left'
  ), $value);

C:\<PROJECT_PATH>\node_modules\video.js\src\css\utilities\_linear-gradient.scss 30:18  is-direction()
C:\<PROJECT_PATH>\node_modules\video.js\src\css\utilities\_linear-gradient.scss 86:7   linear-gradient()       
C:\<PROJECT_PATH>\node_modules\video.js\src\css\components\_modal-dialog.scss 3:3      @import
C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 12:9                     @import
scss\videojs.scss 2:9                                                                      
                                                                   root stylesheet

---

Deprecation Warning on line 43, column 13 of file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/utilities/_linear-gradient.scss:43:13:
Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use meta.type-of instead.

More info and automated migrator: https://sass-lang.com/d/import

43 |   $is-angle: type-of($value) == 'number' and index('deg' 'grad' 'turn' 'rad', unit($value));

C:\<PROJECT_PATH>\node_modules\video.js\src\css\utilities\_linear-gradient.scss 44:14  is-direction()
C:\<PROJECT_PATH>\node_modules\video.js\src\css\utilities\_linear-gradient.scss 86:7   linear-gradient()       
C:\<PROJECT_PATH>\node_modules\video.js\src\css\components\_modal-dialog.scss 3:3      @import
C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 12:9                     @import
scss\videojs.scss 2:9                                                                      
                                                                   root stylesheet

Steps to reproduce

  1. Install sass or sass-embedded
  2. Add @import 'video.js/src/css/video-js.scss'; in the scss file and import it.
  3. See the logs

Errors

No response

What version of Video.js are you using?

8.19.1

rtritto commented 1 week ago

FYI @mister-ben