videojs / video.js

Video.js - open source HTML5 video player
https://videojs.com
Other
38.14k stars 7.46k forks source link

Sass deprecations for @import rules #8910

Open rtritto opened 2 weeks ago

rtritto commented 2 weeks ago

Description

After I updated sass-embedded to version 1.80.5:

Embedded Host

Don't produce phantom @import deprecations when using an importer with the legacy API.

Output

Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.        

More info: https://sass-lang.com/d/legacy-js-api

---

Deprecation Warning on line 0, column 8 of file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/video-js.scss:0:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

0 | @import "icons";

C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 1:9  @import
scss\videojs.scss 2:9                                                                      
                                               root stylesheet

---

Deprecation Warning on line 1, column 8 of file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/video-js.scss:1:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

1 | @import "variables";

C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 2:9  @import
scss\videojs.scss 2:9                                                                      
                                               root stylesheet

---

Deprecation Warning on line 1, column 8 of file:///C:/workspace/1-MyProjects/kai-pwa/scss/videojs.scss:1:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

1 | @import 'video.js/src/css/video-js.scss';

scss\videojs.scss 2:9  root stylesheet

---

Deprecation Warning on line 2, column 8 of file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/video-js.scss:2:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

2 | @import "private-variables";

C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 3:9  @import
scss\videojs.scss 2:9                                                                      
                                               root stylesheet

---

Deprecation Warning on line 3, column 8 of file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/video-js.scss:3:8:
Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

3 | @import "utilities";

C:\<PROJECT_PATH>\node_modules\video.js\src\css\video-js.scss 4:9  @import
scss\videojs.scss 2:9                                                                      
                                               root stylesheet

Steps to reproduce

  1. Install sass or sass-embedded
  2. Add @import 'video.js/src/css/video-js.scss'; in the scss file and import it.
  3. See the logs

Errors

No response

What version of Video.js are you using?

8.19.1

rtritto commented 2 weeks ago

FYI @mister-ben