search

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
384 stars 257 forks source link

Remove the placeholder div logic from cancelContentPlay() #296

Closed alex-barstow closed 6 years ago

alex-barstow commented 7 years ago

The time has come to remove the placeholder div (aka The Black Div of Death) from cancelContentPlay(). Content flash before preroll playback in the iOS native player (the original reason for its creation) is evidently less of an issue in later versions of iOS, and this workaround has caused more problems than it has solved. The decision to remove it comes sanctioned by @incompl and @ldayananda.

incompl commented 7 years ago

LGTM

sunnyCN34 commented 6 years ago

QA- passed Black screen does not appear now in native player of iOS 11 iPhone.