Closed sdahdaah closed 6 years ago
incompl
commented
6 years ago Are you using videojs-ima? videojs-contrib-ads 6 just came out, and it is unlikely that they support it yet. Their package.json points tovideojs-contrib-ads ^5.1.6. You can pick your desired version using the CDN if that's your preference.
sdahdaah
commented
6 years ago I tried this version i got the same issue. If you remove rs and use directly vod-platform.net those old versions are working correctly.
On Monday, February 26, 2018, Greg Smith notifications@github.com wrote:
Are you using videojs-ima https://github.com/googleads/videojs-ima? videojs-contrib-ads 6 just came out, and it is unlikely that they support it yet. Their package.json points to videojs-contrib-ads I would try again with videojs-contrib-ads ^5.1.6. You can pick your desired version using the CDN https://cdnjs.com/libraries/videojs-contrib-ads if that's your preference.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/videojs/videojs-contrib-ads/issues/333#issuecomment-368635935, or mute the thread https://github.com/notifications/unsubscribe-auth/AjJ6w22dH0wIdcJhEdiD0xZpkrIZN8Vvks5tYxGEgaJpZM4ST1XI .
incompl
commented
6 years ago Can you update your example page to not use contrib-ads 6 so I can take a look at what happens in an environment that is known to work? Thanks!
sdahdaah
commented
6 years ago here is an example that uses contribads 5.0.3 the pre post and mid fires
http://vod-platform.net/Embed/uwPUXEHxeBRpHcpRmaronw?responsive=1
below using 6.0 contrib ads with ima 1.1 pre sometimes fires mid and pre never do
http://vod-platform.net/Embed/uwPUXEHxeBRpHcpRmaronw?responsive=1
On Mon, Feb 26, 2018 at 10:28 PM, Greg Smith notifications@github.com wrote:
Can you update your example page to not use contrib-ads 6 so I can take a look at what happens in an environment that is known to work? Thanks!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/videojs/videojs-contrib-ads/issues/333#issuecomment-368638845, or mute the thread https://github.com/notifications/unsubscribe-auth/AjJ6wxRLsP8ZGsQPb86aogHAoAkqT6Y6ks5tYxPTgaJpZM4ST1XI .
incompl
commented
6 years ago It sounds like videojs-ima does work with contrib-ads 5.x but not with 6.x, which is expected. I suggest using 5.x until videojs-ima is updated to support contrib-ads 6. I opened this issue to help hopefully clarify the dependency: https://github.com/googleads/videojs-ima/issues/533
sdahdaah
commented
6 years ago Do you suggest i keep 5.0.3 with latest IMA 1.1? Or i keep the versions i have right now?
On Monday, February 26, 2018, Greg Smith notifications@github.com wrote:
It sounds like videojs-ima does work with contrib-ads 5.x but not with 6.x, which is expected. I suggest using 5.x until videojs-ima is updated to support contrib-ads 6. I opened this issue to help hopefully clarify the dependency: googleads/videojs-ima#533 https://github.com/googleads/videojs-ima/issues/533
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/videojs/videojs-contrib-ads/issues/333#issuecomment-368652556, or mute the thread https://github.com/notifications/unsubscribe-auth/AjJ6w07pO8hsgxov2fUuHXGREJeqDN1gks5tYx6VgaJpZM4ST1XI .
sdahdaah
commented
6 years ago By the way 5.1.6 had the same issue with latest IMA it is not only with 6 i can create an example.
On Monday, February 26, 2018, Salloum EL DAHDAAH s.dahdaah@gmail.com wrote:
Do you suggest i keep 5.0.3 with latest IMA 1.1? Or i keep the versions i have right now?
On Monday, February 26, 2018, Greg Smith notifications@github.com wrote:
It sounds like videojs-ima does work with contrib-ads 5.x but not with 6.x, which is expected. I suggest using 5.x until videojs-ima is updated to support contrib-ads 6. I opened this issue to help hopefully clarify the dependency: googleads/videojs-ima#533 https://github.com/googleads/videojs-ima/issues/533
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/videojs/videojs-contrib-ads/issues/333#issuecomment-368652556, or mute the thread https://github.com/notifications/unsubscribe-auth/AjJ6w07pO8hsgxov2fUuHXGREJeqDN1gks5tYx6VgaJpZM4ST1XI .
incompl
commented
6 years ago I suggest you keep using 5.0.3 if that works for you and report the issue with 5.1.6 to videojs-ima since that is the version they recommend using.
sdahdaah
commented
6 years ago let me give you a quick update, using contrib-ads V6 with IMA copyright 2014 had 0 issue and all worked well.
On Mon, Feb 26, 2018 at 11:19 PM, Greg Smith notifications@github.com wrote:
I suggest you keep using 5.0.3 if that works for you and report the issue with 5.1.6 to videojs-ima since that is the version they recommend using.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/videojs/videojs-contrib-ads/issues/333#issuecomment-368654197, or mute the thread https://github.com/notifications/unsubscribe-auth/AjJ6w-mBnruhAeNCh4n6t5EydzyXufEPks5tYx_ngaJpZM4ST1XI .
sdahdaah
commented
6 years ago Contrib-ads V6 and IMA v 0.8 is working with no issue.
On Mon, Feb 26, 2018 at 11:19 PM, Greg Smith notifications@github.com wrote:
I suggest you keep using 5.0.3 if that works for you and report the issue with 5.1.6 to videojs-ima since that is the version they recommend using.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/videojs/videojs-contrib-ads/issues/333#issuecomment-368654197, or mute the thread https://github.com/notifications/unsubscribe-auth/AjJ6w-mBnruhAeNCh4n6t5EydzyXufEPks5tYx_ngaJpZM4ST1XI .
incompl
commented
6 years ago After investigating, I don't believe I'm able to help you debug your issues with videojs-ima. I suggest opening issues in that project's github.
After updating to the latest version on IMA and Contrib-Ads only pre-roll is fired, mid-roll and post-roll are note being fired.
http://rs.vod-platform.net/Embed/uwPUXEHxeBRpHcpRmaronw
add to the above sometimes pre-roll is hanging after playing 1 second it shows the below error and hangs.
InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable videojs-contrib-hls.min.js:7
get http://rs.vod-platform.net/players/videojs6.2/videojs-contrib-hls/videojs-contrib-hls.min.js:7:18485 value http://rs.vod-platform.net/players/videojs6.2/videojs-contrib-hls/videojs-contrib-hls.min.js:7:22963 value/< http://rs.vod-platform.net/players/videojs6.2/videojs-contrib-hls/videojs-contrib-hls.min.js:3:11728