search

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
384 stars 257 forks source link

Log warning becomes less useful if code minified #338

Closed incompl closed 6 years ago

incompl commented 6 years ago

See: https://github.com/googleads/videojs-ima/issues/539#issuecomment-369944588

The log message is video.bundle.js:5 VIDEOJS: WARN: Unexpected endLinearAdMode invocation (State via r). It says r instead of the state name because the code is minified.

We should update this message to not get messed up by minification.

mysuf commented 6 years ago

The non-minified msg is:

video.bundle.js:9852 VIDEOJS: WARN: Unexpected endLinearAdMode invocation (State via AdsDone)

incompl commented 6 years ago

@mysuf You'll want to post messages related to your specific videojs-ima issue back in https://github.com/googleads/videojs-ima/issues/539 so the maintainers of that project can help.

incompl commented 6 years ago

https://github.com/videojs/videojs-contrib-ads/pull/339

incompl commented 6 years ago

Fixed in 6.0.1.