search

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
384 stars 257 forks source link

An in-range update of uglify-js is breaking the build 🚨 #341

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 6 years ago

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 3.3.13 of uglify-js was just published.

Branch Build failing 🚨
Dependency uglify-js
Current Version 3.3.12
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

uglify-js is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/videojs/videojs-contrib-ads/builds/348876573?utm_source=github_status&utm_medium=notification)
Release Notes v3.3.13

 

Commits

The new version differs by 15 commits.

  • 951d87c v3.3.13
  • 798fc21 improve test/run-test.js performance (#2971)
  • a75a046 compress arguments[index] (#2967)
  • 38f2b45 fix value reference caching in evaluate (#2969)
  • 56e2a36 enhance conditionals (#2966)
  • 0daa199 migrate safe transformations out of unsafe_comps (#2962)
  • 73e98dc drop side_effects-free return values (#2965)
  • 36bca69 enhance collapse_vars (#2952)
  • ace5811 drop lone "use strict" in function body (#2963)
  • ba7bad0 show benchmark subtotal (#2960)
  • b8b2ac5 improve fix for #2954 (#2958)
  • ea23593 fix collapse_vars on nested exception (#2955)
  • 52de64c deduplicate parenthesis around object and function literals (#2953)
  • 4557902 minor clean-ups (#2951)
  • f40f5eb improve mangle (#2948)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 3.3.12 your tests are passing again. Downgrade this dependency 📌.

incompl commented 6 years ago

Seems that #342 was the real issue