search

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
384 stars 257 forks source link

postroll issues #352

Closed Pong420 closed 6 years ago

Pong420 commented 6 years ago

Description

I am using videojs-ima to handle postroll and receive below warning

VIDEOJS: WARN: Unexpected adsready event

Is onAdsReady function missing in Postroll or we should not fire adsready event on postroll

Demo

Another question, fire nopostroll event when contentend will not receive eneded event immediately

player.on("contentended", function(){
   player.trigger("nopostroll")
})

Versions

videojs-contrib-ads version: 6.0.0

Video-js version: 6.7.4

Other plugins: videojs-ima

incompl commented 6 years ago

The adsready event is just for preroll handling. I suggest opening an issue with videojs-ima.

When you say ended event is not immediate after calling nopostroll, do you mean that it is delayed or that it never happens? Which version of videojs-contrib-ads are you using?

Pong420 commented 6 years ago 
player.on("contentended", function(){
   player.trigger("nopostroll")
   // ended event is not received at this moment, until content playback ended again 
})

i am using videojs-contrib-ads 6.0.0

incompl commented 6 years ago

For the nopostroll issue, here is the issue in videojs-ima to track that enhancement on their side: https://github.com/googleads/videojs-ima/issues/567

I don't see an issue there about adsready / postrolls, so I still suggest opening one. I'm closing this issue because there aren't any changes needed on the contrib-ads side.