On IE11, we can potentially receive a play event before adBreak.end() completes and thus before we set this.contentResuming = true;. This results in that play event being prefixed as an ad-play event since contentResuming is still false until after end completes.
This fix simply moves this.contentResuming = true; above the AdBreak.end() call which is in line with what we are also doing in Midroll.js.
Logically, this makes sense because we are adding thevjs-ad-content-resuming class to the player as a signal to the UI that we are done playing ads.
apadhye
commented
6 years ago
On IE11, we can potentially receive a
playevent beforeadBreak.end()completes and thus before we setthis.contentResuming = true;. This results in thatplayevent being prefixed as anad-playevent sincecontentResumingis stillfalseuntil afterendcompletes.This fix simply moves
this.contentResuming = true;above theAdBreak.end()call which is in line with what we are also doing inMidroll.js.Logically, this makes sense because we are adding the
vjs-ad-content-resumingclass to the player as a signal to the UI that we are done playing ads.Tested on IE11 on Win7 and on Mac OS X Chrome 67.