search

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
381 stars 257 forks source link

Ad not playing when changing source while an ad is playing #450

Open mimse opened 5 years ago

mimse commented 5 years ago

Description

Changing source during an ad will cause the plugin state to be faulty.

Steps to Reproduce

Use example basic-ad-plugin.

Expected Results

The ad should play after setting a new source while an ad is playing

Actual Results

The content starts to play instead of an ad when setting a new source while an ad is playing

Versions

videojs-contrib-ads version: 6.6.1

**Video-js version: 7.3.0

Platforms

Browsers: Chrome v70

OS/Devices: macOS Mojave

mysuf commented 5 years ago

I already reported this in #445, but its better to have it in separate ticket..

incompl commented 5 years ago

I made a PR that I think might work for this, would you mind trying it out? https://github.com/videojs/videojs-contrib-ads/pull/455