search

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
381 stars 257 forks source link

An in-range update of video.js is breaking the build 🚨 #481

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency video.js was updated from 7.5.3 to 7.5.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

video.js is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/videojs/videojs-contrib-ads/builds/521777152?utm_source=github_status&utm_medium=notification)).
Release Notes for v7.5.4

7.5.4 (2019-04-12)

Bug Fixes

  • always show the mute button by default in responsive mode (#5914) (c85bc00)
  • call reset if we are paused or no promises, otherwise wait for play promise to resolve (#5876) (5973a62), closes #5875
  • correctly resolve play promise when terminated via middleware (#5895) (ad53b80)
  • explicitly remove all document-level listeners on player dispose (#5929) (458a5ea)
  • fix bug preventing control bar from hiding on mobile (#5836) (1844482)
  • fix fullscreen detection when player is nested within document fullscreen (#5912) (22d0514)
  • hide the progress control and show the subs-caps button when using Live UI at extra small size (#5915) (55b3752)

Documentation

  • ModalDialog: add missing documentation for pauseOnOpen (#5908) (b2eae7b)
Commits

The new version differs by 10 commits.

  • 1a52b69 7.5.4
  • 5973a62 fix: call reset if we are paused or no promises, otherwise wait for play promise to resolve (#5876)
  • ad53b80 fix: correctly resolve play promise when terminated via middleware (#5895)
  • 1844482 fix: fix bug preventing control bar from hiding on mobile (#5836)
  • 22d0514 fix: fix fullscreen detection when player is nested within document fullscreen (#5912)
  • cd07341 lang: fix typo in de translation (#5920)
  • 458a5ea fix: explicitly remove all document-level listeners on player dispose (#5929)
  • 55b3752 fix: hide the progress control and show the subs-caps button when using Live UI at extra small size (#5915)
  • c85bc00 fix: always show the mute button by default in responsive mode (#5914)
  • b2eae7b docs(ModalDialog): add missing documentation for pauseOnOpen (#5908)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 7.5.3 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.