Fix: on auto-play don't request playback for stitched ads as well as when playback already started

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins

http://videojs.github.io/videojs-contrib-ads/

Other

381 stars 257 forks source link

Fix: on auto-play don't request playback for stitched ads as well as when playback already started #486

Closed bcdarius closed 5 years ago

bcdarius commented 5 years ago

Some techs, e.g. Flash may re-trigger canplay after playback has begun which can result in requesting playback when playback is already progressing. When assuming auto-play, playback should be requested only if it hasn't started. We also don't need to handle auto-playback for stitched ads because linear ads in such cases are stitched into the content.

bcdarius commented 5 years ago

@misteroneill That's a good point, for stitched ads this handler is redundant.

bcdarius commented 5 years ago

@misteroneill Is this good to go? Thanks