videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
379 stars 257 forks source link

Does videojs-contrib-ads support Amazon IVS player? #529

Open coooo77 opened 3 years ago

coooo77 commented 3 years ago

Description

Registering Amazon IVS as playback technology for Video.js and fail to play video.

Steps to Reproduce

  1. clone code

    git clone https://github.com/coooo77/video-js-ivs-player-ad.git
    cd video-js-ivs-player-ad
  2. Install dependencies

    npm install
  3. open index.html

Expected Results

Amazon IVS player plays pre-roll advertising and video

Actual Results

Pre-roll ad played but fail to play video and get TypeError: Cannot read property 'src' of null

Versions

videojs-contrib-ads version: 6.7.0

Video-js version: 7.6.6

Other plugins:

Platforms

Browsers: Chrome v89

OS/Devices: Windows 10

gkatsev commented 3 years ago

Looks like it doesn't work. At first glance I'm not sure why, I'd expect it to work. One thing I noticed that's a bit weird is that their tech doesn't return a value for the src() method. We'd have to investigate exactly why it's broken but unfortunately, I'm not sure that we have the bandwidth for that right now. Any help on that front would be greatly appreciated.